Skip to content

disable test with : on WIN#400

Merged
petdance merged 5 commits into
beyondgrep:devfrom
n1vux:dev
Jun 11, 2026
Merged

disable test with : on WIN#400
petdance merged 5 commits into
beyondgrep:devfrom
n1vux:dev

Conversation

@n1vux

@n1vux n1vux commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Crude test, will disabling the whole test make Win CI complete.
(Will likely refine to allow tests for 2 ANSI test cases to run on Win?)

@n1vux

n1vux commented Jun 7, 2026

Copy link
Copy Markdown
Contributor Author

So. Not only is "real\nFORGED:999:foo" a bad filename on WIN, so is the ANSI text in RED test: WIN chokes on at least one of the embedded ESC or the [ as well as at least one of the embedded newline, :.
Good, Windows doesn't need to be protected from this hack.

(The filtering protection on output will still operate, might be useful in case of a mounted filesystem?, but we can't test it on Win.)

So the whole t/naughty-filenames.t is unnecessary for Windows, so reverting back to simple skip_all which worked.

@petdance petdance merged commit 48528db into beyondgrep:dev Jun 11, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants